Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE1] Fix a segmentation fault #1909

Conversation

arnauds5
Copy link
Collaborator

@arnauds5 arnauds5 commented Jun 4, 2024

Add a null check to avoid a segmentation fault when an answer id is null.

SIGSEGV

@arnauds5 arnauds5 added be1-go bug-fix Fixes a bug labels Jun 4, 2024
@arnauds5 arnauds5 requested a review from a team as a code owner June 4, 2024 11:50
Copy link

github-actions bot commented Jun 4, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
15
▀▀▀
4d 7h 58m
14
▀▀▀
onsriahi14
🥈
5
1d 1h 53m
5
simone-kalbermatter
🥉
4
8h 40m
0
matteosz
4
4d 1h 8m
5
DanielTavaresA
3
2d 19h 23m
10
▀▀
pierluca
2
3d 11h 3m
1
arnauds5
2
5d 15h 3m
▀▀
0
emonnin-epfl
2
3h 14m
2
quadcopterman
2
6d 13h 46m
▀▀
1
Tyratox
1
44m
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

@emonnin-epfl
Copy link
Contributor

Would you mind applying the fix on the be1-stuart-etienne-top-down-injection branch instead? Thank you!

Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll let you change the target branch according to @emonnin-epfl's comment.

@arnauds5 arnauds5 changed the base branch from master to work-be1-stuart-etienne-top-down-injection June 5, 2024 16:05
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arnauds5 arnauds5 merged commit e3fba6b into work-be1-stuart-etienne-top-down-injection Jun 5, 2024
13 checks passed
@arnauds5 arnauds5 deleted the work-be1-arnauds5-fix-segmention-fault branch June 5, 2024 16:09
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants