[BE2] Integration of linter in the main code #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tripMarginOnRegex
… work-be2-thibault-linter-integration # Conflicts: # be2-scala/linter/rules/src/main/scala/fix/ArraysInFormat.scala # be2-scala/linter/rules/src/main/scala/fix/ComparingFloatingTypes.scala # be2-scala/linter/rules/src/main/scala/fix/EmptyInterpolatedString.scala # be2-scala/linter/rules/src/main/scala/fix/IllegalFormatString.scala # be2-scala/linter/rules/src/main/scala/fix/IncorrectlyNamedExceptions.scala # be2-scala/linter/rules/src/main/scala/fix/LonelySealedTrait.scala # be2-scala/linter/rules/src/main/scala/fix/OptionGet.scala # be2-scala/linter/rules/src/main/scala/fix/OptionSize.scala # be2-scala/linter/rules/src/main/scala/fix/StripMarginOnRegex.scala # be2-scala/linter/rules/src/main/scala/fix/TryGet.scala # be2-scala/linter/rules/src/main/scala/fix/Util.scala
Pull reviewers statsStats of the last 30 days for popstellar:
|
An error occurred while trying to automatically change base from
work-be2-thibault-linter_master
to
master
June 17, 2024 12:12
K1li4nL
reviewed
Jun 18, 2024
|
K1li4nL
approved these changes
Jun 19, 2024
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR makes the linter publishable, with modifications to the build.sbt of the linter and provides documentation in the README.md.
Small modification at the end of build.sbt of the main project (most edits were done by automatic cleanup), that adds custom rules
Rules use a diag() function instead of a class, which would cause compilation errors in Scala 3