Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE1] Add a simple buffer to rumor #1920

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Conversation

sgueissa
Copy link
Collaborator

@sgueissa sgueissa commented Jun 12, 2024

this PR add the first version of the buffer for the simple version of the rumors without the state inside the rumor.

It will be upgraded once the new rumor message is created.

@sgueissa sgueissa self-assigned this Jun 12, 2024
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
17
▀▀▀▀
3d 22h 19m
14
▀▀▀
simone-kalbermatter
🥈
4
8h 40m
0
onsriahi14
🥉
4
1d 10h 51m
5
matteosz
4
21h 47m
3
arnauds5
3
2d 22h 36m
2
emonnin-epfl
3
8h 20m
8
▀▀
pierluca
2
3d 11h 3m
1
MariemBaccari
2
22h 39m
6
DanielTavaresA
2
9d 21h 46m
▀▀▀
2
Tyratox
1
44m
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

Base automatically changed from work-be1-stuart-better-logging to master June 12, 2024 19:31
@sgueissa sgueissa marked this pull request as ready for review June 13, 2024 15:31
@sgueissa sgueissa requested a review from a team as a code owner June 13, 2024 15:31
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgueissa sgueissa enabled auto-merge June 14, 2024 12:35
Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind approval

@sgueissa sgueissa added this pull request to the merge queue Jun 14, 2024
Merged via the queue into master with commit d8c2bba Jun 14, 2024
17 checks passed
@sgueissa sgueissa deleted the work-be1-stuart-buffer-rumor branch June 14, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants