Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE1] Increase usability of module with handlers #1928

Merged

Conversation

sgueissa
Copy link
Collaborator

In this PR, I changed the switch inside the modules query and message to allow future users to be able to add new methods and channels without having to directly change those modules.

Maybe we should return an error in each New() function if one of the argument is nil in a future PR.

@sgueissa sgueissa self-assigned this Jun 13, 2024
@sgueissa sgueissa requested a review from a team as a code owner June 13, 2024 15:27
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
18
▀▀▀▀
3d 20h 55m
14
▀▀▀
onsriahi14
🥈
4
1d 10h 51m
5
matteosz
🥉
4
21h 47m
3
arnauds5
3
2d 22h 36m
2
simone-kalbermatter
3
1h 47m
0
emonnin-epfl
3
8h 20m
8
▀▀
pierluca
2
3d 11h 3m
1
MariemBaccari
2
22h 39m
6
DanielTavaresA
2
9d 21h 46m
▀▀▀
2
Tyratox
1
44m
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

@sgueissa sgueissa changed the base branch from master to work-be1-stuart-buffer-rumor June 13, 2024 15:28
Copy link
Collaborator

@arnauds5 arnauds5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@emonnin-epfl emonnin-epfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

@sgueissa sgueissa merged commit 688f4a1 into work-be1-stuart-buffer-rumor Jun 14, 2024
14 checks passed
@sgueissa sgueissa deleted the work-be1-stuart-replace-some-switch branch June 14, 2024 12:31
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants