Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix embedme not working #1933

Merged
merged 7 commits into from
Jun 14, 2024
Merged

fix embedme not working #1933

merged 7 commits into from
Jun 14, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

@DanielTavaresA DanielTavaresA commented Jun 14, 2024 •
edited
Loading

Characters " ` " were escaped. But for some reason, matching regex didn't trigger. When those characters are not escaped, matching regex for json code is triggered.

@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 18
▀▀▀▀		 2d 10h 24m
▀		 10
▀▀▀
arnauds5
🥈		 5
▀		 1d 5h 11m
 3
▀
emonnin-epfl
🥉		 5
▀		 8h 20m
 9
▀▀▀
simone-kalbermatter
 3
▀		 1h 47m
 0
onsriahi14
 3
▀		 23h 11m
 1
matteosz
 3
▀		 14h 5m
 3
▀
pierluca
 2
 3d 11h 3m
▀		 1
MariemBaccari
 2
 22h 39m
 6
▀▀
DanielTavaresA
 2
 9d 21h 46m
▀▀▀▀		 2
▀
sgueissa
 1
 6d 11h 44m
▀▀		 1
⚡️ Pull request stats

@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Merged
@github-actions GitHub Actions
Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1934 first.

@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Merged
@github-actions GitHub Actions
Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1935 first.

@github-actions GitHub Actions
Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1935 first.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@DanielTavaresA DanielTavaresA requested a review from K1li4nL June 14, 2024 14:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

K1li4nL
K1li4nL approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@K1li4nL K1li4nL added this pull request to the merge queue Jun 14, 2024
Merged via the queue into master with commit 0450bf5 Jun 14, 2024
17 checks passed
@K1li4nL K1li4nL deleted the work-bug-daniel-embedme branch June 14, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielTavaresA @K1li4nL