New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Copy Token Button Never Disappears #1966

Merged

matteosz merged 4 commits into master from work-fe2-maxime-fix-1961

Jun 30, 2024

Contributor

Kaz-ookid commented Jun 28, 2024

quick fix addressing #1961

Kaz-ookid added 2 commits

June 28, 2024 15:07


          stash

4f021dc


          fixed roll call token copy button staying visible when shouldn't + te…

928f8c8

…sts that is never happens again

Kaz-ookid requested a review from a team as a code owner

June 28, 2024 13:37

github-actions bot commented Jun 28, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	25 ▀▀▀▀	1d 19h 11m ▀	12 ▀▀
	matteosz 🥈	9 ▀	2d 20h 40m ▀	22 ▀▀▀
	arnauds5 🥉	7 ▀	4h 29m	4 ▀
	emonnin-epfl	6 ▀	8h 20m	8 ▀
	sgueissa	4 ▀	1h 25m	7 ▀
	quadcopterman	3	10d 7h 3m ▀▀▀	1
	1florentin	2	10d 5h 50m ▀▀▀	0
	MariemBaccari	2	22h 39m	6 ▀
	simone-kalbermatter	2	5h 32m	0
	onsriahi14	2	6d 4h 27m ▀▀	4 ▀
	Kaz-ookid	2	2d 4h 12m ▀	9 ▀
^{⚡️ Pull request stats}

Kaz-ookid added 2 commits

June 28, 2024 15:38


          Revert "stash"

96d1a45

This reverts commit 4f021dc.


          fmt + removed unwanted changes from other branch

0bd4058

sonarqubecloud bot commented Jun 28, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud bot commented Jun 28, 2024

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud bot commented Jun 28, 2024

Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud bot commented Jun 28, 2024

Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Kaz-ookid self-assigned this

Kaz-ookid added the fe2-android label

Kaz-ookid linked an issue

that may be closed by this pull request

[BUG] Copy button on RollCalls never disappears #1961

Closed

matteosz approved these changes

View reviewed changes

Contributor

matteosz left a comment

LGTM

matteosz added this pull request to the merge queue

Merged via the queue into master with commit 024f340

17 checks passed

matteosz deleted the work-fe2-maxime-fix-1961 branch

June 30, 2024 12:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels