fix(2010): fix disabled dropdown item was able to click

deepfence · Nov 28, 2023 · 8ad9c4c · 8ad9c4c
1 parent d0daf9f
commit 8ad9c4c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/deepfence_frontend/apps/dashboard/src/features/postures/pages/Accounts.tsx b/deepfence_frontend/apps/dashboard/src/features/postures/pages/Accounts.tsx
@@ -546,7 +546,7 @@ const ActionDropdown = ({
           <>
             <DropdownItem
               disabled={isScanInProgress(scanStatus) || isScanStopping(scanStatus)}
-              onClick={() => {
+              onSelect={() => {
                 if (!nodeId) {
                   throw new Error('Node id is required to start scan');
                 }
@@ -586,6 +586,7 @@ const ActionDropdown = ({
               <span
                 className={cn('flex items-center gap-x-2', {
                   'text-red-700 dark:text-status-error': scanId,
+                  'dark:text-df-gray-600': !scanId || !nodeType,
                 })}
               >
                 Delete latest scan

diff --git a/deepfence_frontend/apps/dashboard/src/features/vulnerabilities/pages/VulnerabilityScans.tsx b/deepfence_frontend/apps/dashboard/src/features/vulnerabilities/pages/VulnerabilityScans.tsx
@@ -9,6 +9,7 @@ import {
   useSearchParams,
 } from 'react-router-dom';
 import { toast } from 'sonner';
+import { cn } from 'tailwind-preset';
 import {
   Badge,
   Breadcrumb,
@@ -415,7 +416,11 @@ const ActionDropdown = ({
               }}
               disabled={isScanInProgress(scanStatus)}
             >
-              <span className="flex items-center text-red-700 dark:text-status-error">
+              <span
+                className={cn('flex items-center text-red-700 dark:text-status-error', {
+                  'dark:text-df-gray-600': isScanInProgress(scanStatus),
+                })}
+              >
                 Delete
               </span>
             </DropdownItem>