Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base64 encode the api token #1792

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Base64 encode the api token #1792

merged 1 commit into from
Nov 30, 2023

Conversation

ramanan-ravi
Copy link
Collaborator

Sometimes users skip copying the namespace which is part of the api token, because it looks unusual

@ramanan-ravi
Base64 encode the api token
5523ded 
Sometimes users skip copying the namespace which is part of the api token, because it looks unusual
@gnmahanth gnmahanth requested a review from noboruma November 30, 2023 09:02
gnmahanth
gnmahanth approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@gnmahanth gnmahanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramanan-ravi ramanan-ravi merged commit 6b4c8e5 into main Nov 30, 2023
4 checks passed
@ramanan-ravi ramanan-ravi deleted the api-token branch November 30, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnmahanth gnmahanth gnmahanth approved these changes

@noboruma noboruma Awaiting requested review from noboruma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramanan-ravi @gnmahanth