Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-1466: Enhance the pdf report generation #1804

Conversation

GirishCodeAlchemy
Copy link
Contributor

@GirishCodeAlchemy GirishCodeAlchemy commented Dec 3, 2023

Fixes #

Changes proposed in this pull request:

  • Added pie chart to display the summary of Severity
  • Update the ScanResults property as it is currently breaking the report generation for the vulnerability table.

latest pdf report :
vulnerability_container_6063e1e1-1054-4fc2-8e2c-e25ab20b949b.pdf

Pie chart to display overall severity:
image

Changes:
1. Created pie chart to display the overall summary of severity
2. Fix the vulnerability table with latest model keys
@ramanan-ravi ramanan-ravi requested review from noboruma and manV December 4, 2023 06:57
@@ -151,11 +160,14 @@ func getVulnerabilityData(ctx context.Context, params sdkUtils.ReportParams) (*I
params.Filters.SeverityOrCheckType, params.Filters.AdvancedReportFilters.Masked)

nodeWiseData := NodeWiseData[model.Vulnerability]{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was there before that PR but this could be simplified a lot across model.Secret, model.Vulnerability and so on

Copy link
Collaborator

@noboruma noboruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good on backend side
(The revamp/cleanup would be great to have)

@gnmahanth
Copy link
Contributor

closing this PR as we no longer use the method where we covert html to pdf

@gnmahanth gnmahanth closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants