Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove table attribute size cutoff limit #5628

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: Remove table attribute size cutoff limit #5628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ public class BarrageUtil {
/** The name of the attribute that indicates that a table is flat. */
public static final String TABLE_ATTRIBUTE_IS_FLAT = "IsFlat";

private static final int ATTR_STRING_LEN_CUTOFF = 1024;

private static final String ATTR_DH_PREFIX = "deephaven:";
private static final String ATTR_ATTR_TAG = "attribute";
private static final String ATTR_ATTR_TYPE_TAG = "attribute_type";
Expand Down Expand Up @@ -255,8 +253,7 @@ public static Map<String, String> attributesToMetadata(
final Object val = entry.getValue();
if (val instanceof Byte || val instanceof Short || val instanceof Integer ||
val instanceof Long || val instanceof Float || val instanceof Double ||
val instanceof Character || val instanceof Boolean ||
(val instanceof String && ((String) val).length() < ATTR_STRING_LEN_CUTOFF)) {
val instanceof Character || val instanceof Boolean || val instanceof String) {
// Copy primitives as strings
putMetadata(metadata, ATTR_ATTR_TAG + "." + key, val.toString());
putMetadata(metadata, ATTR_ATTR_TYPE_TAG + "." + key, val.getClass().getCanonicalName());
Expand Down
Loading