build: DH-18477: Java coverage generated conditionally #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanbrub
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested changes
Jan 22, 2025
buildSrc/src/main/groovy/io.deephaven.java-test-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-jacoco-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-jacoco-conventions.gradle
Outdated
Show resolved
Hide resolved
Comment on lines
+5
to
+6
| // Apply Jacoco instrumentation and coverage reporting | ||
| if (project.findProperty('coverage.enabled') == 'true') { |
There was a problem hiding this comment.
@niloc132; I wonder if we should unconditionally apply the jacoco plugin.
There was a problem hiding this comment.
Would that affect things like JMH because of instrumentation?
buildSrc/src/main/groovy/io.deephaven.java-jacoco-conventions.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-jacoco-conventions.gradle
Outdated
Show resolved
Hide resolved
| jacoco { | ||
| destinationFile = layout.buildDirectory.file('jacoco/jacoco.exec').get().asFile | ||
| } | ||
| finalizedBy jacocoTestReport | ||
| } | ||
|
|
||
| jacocoTestReport { |
There was a problem hiding this comment.
We may need to look into hooking up integration tests as part of the coverage path. Right now, it seems like only the "test" task is included for the reporting. https://docs.gradle.org/current/userguide/jacoco_plugin.html#sec:jacoco_tasks
There was a problem hiding this comment.
In the README.md I have the expected command line for running everything. Are there more than check, testSerial, testParallel, testOutOfBand? How to I run anything that's missing?
stanbrub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java coverage in the DHC build with Jacoco was broken at some point. Fixed that and added coverage merge. Full coverage can be run and merged with the following:
This produces HTML, CSV, XML coverage artifacts at the Java project level. It also produces a merged HTML site in the root "build/reports" directory.
If the "coverage.enabled" property is not supplied or is false, "check" will run as usual without instrumentation.
Jira: https://deephaven.atlassian.net/browse/DH-18477