feat: add LastBy / FirstBy features to NaturalJoin
#6604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
changed the title
LastBy / FirstBy features to NaturalJoin
… 100% in alternate.
lbooker42
added
query engine
DocumentationNeeded
ReleaseNotesNeeded
lbooker42
commented
Jan 31, 2025
...ble/src/main/java/io/deephaven/engine/table/impl/BothIncrementalNaturalJoinStateManager.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
...eephaven/engine/table/impl/naturaljoin/RightIncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
lbooker42
requested review from
devinrsmith,
nbauernfeind,
niloc132,
rcaudy,
cpwright,
chipkent and
jmao-denver
as code owners
devinrsmith
reviewed
Feb 3, 2025
cpwright
reviewed
Feb 3, 2025
proto/proto-backplane-grpc/src/main/proto/deephaven_core/proto/table.proto
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/NaturalJoinHelper.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/NaturalJoinHelper.java
Outdated
Show resolved
Hide resolved
...ain/java/io/deephaven/engine/table/impl/naturaljoin/StaticHashedNaturalJoinStateManager.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
.../io/deephaven/engine/table/impl/naturaljoin/IncrementalNaturalJoinStateManagerTypedBase.java
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Feb 3, 2025
proto/proto-backplane-grpc/src/main/proto/deephaven_core/proto/table.proto
Outdated
Show resolved
Hide resolved
…queStaticNaturalJoinStateManager
devinrsmith
reviewed
Feb 4, 2025
jmao-denver
reviewed
Feb 4, 2025
Comment on lines
+347
to
+348
| result_table_2 = left_table.natural_join(right_table_raw, on="key", joins="rhs_index=index", type=NaturalJoinType.LAST_MATCH) | ||
|
|
There was a problem hiding this comment.
Do we need to test the other enum values? The same question for the client test.
There was a problem hiding this comment.
I don't think so. The options are tested heavily in Java already and we are primarily ensuring GRPC and the python client are plumbed correctly.
… implemented in NaturalJoin.
jmao-denver
reviewed
Feb 5, 2025
|
|
||
| Returns: | ||
| self | ||
| """ | ||
| return super().natural_join(table, on, joins) | ||
| return super().natural_join(table, on, joins, type) |
There was a problem hiding this comment.
Maybe add a simple test in test_query.py. I am not insistent on that.
cpwright
reviewed
Feb 5, 2025
engine/table/src/main/java/io/deephaven/engine/table/impl/by/typed/TypedHasherFactory.java
Outdated
Show resolved
Hide resolved
cpwright
approved these changes
Feb 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to specify the row to include when there are duplicates of RHS rows.
Choices are:
exactJoin, requires exactly one RHS row for every LHS row