Skip to content

Commit

Permalink
[fix][ci] install awscli via pip due to issues with using apt (#2684)
Browse files Browse the repository at this point in the history
  • Loading branch information
siddvenk authored Jan 24, 2025
1 parent 290f964 commit 58eb48b
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 26 deletions.
20 changes: 14 additions & 6 deletions .github/workflows/docker-nightly-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,14 @@ jobs:
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
- name: install awscli
- name: Set up Python3
uses: actions/setup-python@v5
with:
python-version: '3.10.x'
- name: Install pip dependencies
run: |
sudo apt-get update
sudo apt-get install awscli -y
python -m pip install --upgrade pip
pip install awscli
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down Expand Up @@ -129,10 +133,14 @@ jobs:
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
- name: install awscli
- name: Set up Python3
uses: actions/setup-python@v5
with:
python-version: '3.10.x'
- name: Install pip dependencies
run: |
sudo apt-get update
sudo apt-get install awscli -y
python -m pip install --upgrade pip
pip install awscli
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
18 changes: 1 addition & 17 deletions .github/workflows/integration_execute.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,27 +70,11 @@ jobs:
echo "wait dpkg lock..."
while sudo fuser /var/{lib/{dpkg,apt/lists},cache/apt/archives}/lock >/dev/null 2>&1; do sleep 5; done
- name: Set up Python3
if: ${{ needs.create-runners.outputs.label != 'aarch64' }}
uses: actions/setup-python@v5
with:
python-version: '3.10.x'
- name: Set up Python3 (aarch64)
if: ${{ needs.create-runners.outputs.label == 'aarch64' }}
run: |
# Using an alternate installation because of an incompatible combination
# of aarch64 with ubuntu-20.04 not supported by the actions/setup-python
sudo apt-get install python3 python-is-python3 python3-pip -y
- name: Install pip dependencies
run: pip3 install pytest requests "numpy<2" pillow huggingface_hub
- name: Install torch
# Use torch to get cuda capability of current device to selectively run tests
# Torch version doesn't really matter that much
run: |
pip3 install torch==2.3.0
- name: install awscli
run: |
sudo apt-get update
sudo apt-get install awscli -y
run: pip3 install pytest requests "numpy<2" pillow huggingface_hub awscli torch
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/nightly-docker-ecr-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,14 @@ jobs:
working-directory: serving/docker
run: |
yes | docker system prune -a --volumes
- name: install awscli
- name: Set up Python3
uses: actions/setup-python@v5
with:
python-version: '3.10.x'
- name: Install pip dependencies
run: |
sudo apt-get update
sudo apt-get install awscli -y
python -m pip install --upgrade pip
pip install awscli
- name: Pull and sync nightly docker image
working-directory: serving/docker
run: |
Expand Down

0 comments on commit 58eb48b

Please sign in to comment.