-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sharding with PP_Degree > 1 #2717
Draft
HappyAmazonian
wants to merge
21
commits into
deepjavalibrary:master
Choose a base branch
from
HappyAmazonian:instance_size
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support Sharding with PP_Degree > 1 #2717
HappyAmazonian
wants to merge
21
commits into
deepjavalibrary:master
from
HappyAmazonian:instance_size
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into djl-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Sharding with PP_Degree > 1
NeoShardingService
classsave_configs
so it save info to model config obj gradually. It will only output the file to disk when it gets the last pp_rank.pp_rank_to_shard
param toshard_lmi_dist_model
run_sharding
, we create a loop of pp_degree, so it calls shard_lmi_dist_model for each pp_rank.this will break if the lmi_dist is not updated
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
Feature/Issue validation/testing
Tested with
llama3 405b pp=2 tp=8, sharded on one instance, and tested serving with two p4de instances.
llama3 8b pp=2 tp=4, sharded on one instance, and tested serving with two g6.12xlarge instances.
llama3 8b pp=1 tp=4, sharded on one instance, and tested serving with one g6.12xlarge instances.