Update container image in a6000 test #5204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
commented
Mar 6, 2024
| @@ -23,7 +23,7 @@ jobs: | |||
| unit-tests: | |||
| runs-on: [self-hosted, nvidia, a6000] | |||
| container: | |||
| image: nvcr.io/nvidia/pytorch:23.03-py3 | |||
There was a problem hiding this comment.
This can be updated after #5167 completes.
|
Re-open and complete this PR later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing image used here (pytorch:23.03-py3) has versions of thinc (8.1.9), spacy (3.5.1), and confection (0.0.4) that do not support pydantic > 1.11.0.
We test updating to a newer image (pytorch:23.09-py3) that has newer versions of thinc (8.1.12), spacy (3.6.1), and confection (0.1.3). These versions all have pydantic < 3.0.0 in their requirements.txt, so we should be safe to update to this version.