Skip to content

Commit

Permalink
fix: comment
Browse files Browse the repository at this point in the history
  • Loading branch information
0xnigir1 committed Oct 23, 2024
1 parent f9c552e commit c03812b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion packages/shared/src/types/events/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ export type ProtocolEvent<T extends ContractName, E extends ContractToEventName<
: never;
};

//TODO: check if this is the best way
/**
* TODO: This type is currently only used in the EventsFetcher and IndexerClient.
* In the future, we should evaluate if a more decoupled or generic type is needed
* to improve flexibility and reduce dependencies across different parts of the system.
* Consider creating separate event types for different contexts if necessary.
*/
export type AnyProtocolEvent = Omit<
ProtocolEvent<ContractName, ContractToEventName<ContractName>>,
"strategyId"
Expand Down

0 comments on commit c03812b

Please sign in to comment.