feat: add whitelist tokens #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkenj1
reviewed
Oct 21, 2024
| CELO: "celo" as CoingeckoTokenId, | ||
| CUSD: "celo-dollar" as CoingeckoTokenId, | ||
| AVAX: "avalanche-2" as CoingeckoTokenId, | ||
| MTK: undefined, |
There was a problem hiding this comment.
why we have undefined here instead of not having it ?
There was a problem hiding this comment.
not strictly needed, it was for clarity (mainly for me when checking at Coingecko)
| 42: "lukso-token" as CoingeckoTokenId, | ||
| 42220: "celo" as CoingeckoTokenId, | ||
| 1088: "metis-token" as CoingeckoTokenId, | ||
| const TokenMapping: { [key: string]: CoingeckoTokenId | undefined } = { |
There was a problem hiding this comment.
should we add a type for keys ?
Could happen that is not supported in coingecko but in cmc , is that we want that flexibility on the key type?
There was a problem hiding this comment.
the flexibility is because with TokenCode as type, i would have to write:
["USDC" as TokenCode]: "usd-coin" as CoingeckoTokenId,
which seems too much, i think this is an issue of using Brand Types as type of object's keys
i thought of a Union type too 🤔 don't know if it'll add any benefit here
0xkenj1
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-111 GIT-66
Description
PricingProviderinterface to useTokenCodein place of (addreess, chainId)TokenCodetoCoingeckoIDPoolCreatedHandlerto fetch Token given the Chain and TokenAddress from EventChecklist before requesting a review