refactor: singleton pattern for logging #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahabeebs
previously approved these changes
Dec 27, 2024
| export const createKyselyPostgresDb = (config: DatabaseConfig): Kysely<Database> => { | ||
| export const createKyselyPostgresDb = ( | ||
| config: DatabaseConfig, | ||
| logger?: ILogger, |
There was a problem hiding this comment.
Optional refactoring suggestion:
When we were working on ebo, Yaco had a nice suggestion to avoid having an optional logger everywhere--you can use the null object design pattern and so if the logger doesn't exist it simply won't log rather than having to handle all the cases it might be null. You can check out the ebo agent repo for the implementation
There was a problem hiding this comment.
ooo love this, will implement this
There was a problem hiding this comment.
well actually will take it into account when we implement Notifications (as you did in EBO), for the Notification service
jahabeebs
approved these changes
Dec 27, 2024
0xyaco
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-204
Description
We re-analyzed the multiple instances of Logger and agreed that is best to have a singleton. So we rollbacked to the original solution of a singleton instance and improved its capabilities with a context object to log more information
Checklist before requesting a review