feat: error classification #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
approved these changes
Jan 7, 2025
|
|
||
| if (pgError instanceof Error && "code" in pgError) { | ||
| // Connection errors | ||
| if (pgError.code === "57P01" || pgError.code === "57P03") { |
There was a problem hiding this comment.
Just as a super nice to have and adding more context to this, Postgres error codes might change in future versions; they are more or less stable though so one error changing from one code to another is pretty weird (but it can happen).
I'd say that grouping these error codes in some kind of versioned error dictionary would be amazing, based on the version you used as a reference. That way, if for some reason someone ends up using PG 20 in the future for this, they only need to change the error dictionary in use.
There was a problem hiding this comment.
ooo that certainly will be a next level feature but super true. will add it to the Linear to have it tracked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-221
Description
We make all custom exception on the project to extend Retriable or NonRetriable base errors classes
Also, we create some new exceptions where needed
Checklist before requesting a review