feat: fetch complete block numbers & ignore false positive error #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
reviewed
Jan 9, 2025
jahabeebs
approved these changes
Jan 9, 2025
| @@ -10,13 +13,11 @@ export interface IEventsFetcher { | |||
| * @param chainId id of the chain | |||
| * @param blockNumber block number to fetch events from | |||
| * @param logIndex log index in the block to fetch events from | |||
| * @param limit limit of events to fetch | |||
| * @param limit limit of events to fetch\ | |||
There was a problem hiding this comment.
will fix in another PR the typo
| */ | ||
| private async getTotalEventsInBlock( | ||
| chainId: ChainId, | ||
| blockNumber: number, |
There was a problem hiding this comment.
Are we wanting to use the {} syntax for just if there are 3+ params?
There was a problem hiding this comment.
we have to define our standard but given this is a private method, i wouldn't be so strict on the option, probably for public methods or interfaces is more important to follow the standard of {}
0xyaco
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GIT-228
Description
Some strategies throw false positive errors for the
TimestampUpdatedevent because on contract init, it emit the events before thePoolCreatedevent (all in the same transaction). This causes that the TimestampUpdated handler doesn't find the Pool and throw an error, however this is expected behaviour (from contract's perspective).To circumvent this, we need to have more events context to determine if the error was thrown on this edge case or is a real error. So we update the Indexer Client to:
Checklist before requesting a review