Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade solc-typed-ast to v18.2.4 #63

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

0xChin
Copy link
Member

@0xChin 0xChin commented Dec 30, 2024

Adds support to solidity 0.8.27 and solidity 0.8.28

@gas1cent gas1cent requested a review from 0xteddybear December 30, 2024 15:26
Copy link
Contributor

@0xteddybear 0xteddybear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding a test (most likely in test/parser/test.ts) testing something that breaks with the previous version of the parser but is handled well with the new one (no need to test all breaking changes, just what made you realize this had to be updated is enough)

@0xChin
Copy link
Member Author

0xChin commented Jan 1, 2025

consider adding a test (most likely in test/parser/test.ts) testing something that breaks with the previous version of the parser but is handled well with the new one (no need to test all breaking changes, just what made you realize this had to be updated is enough)

Every test in the parser runs the following line in the beforeAll statement:

const compileResult = await getFileCompiledSource('test/contracts/ParserTest.sol');

When it tries to compile a version not supported by the AST parser, it breaks, so I'm upgrading all contracts version to latest this way test will break with the previous version of the parser but is handled well with the new one

@0xteddybear lmk if this is enough

Edit: Just modified the testing approach, now there is a LatestVersion contract and a specific test in test/parser/test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants