Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: config #7

Merged
merged 21 commits into from
Jan 11, 2024
Merged

feat: config #7

merged 21 commits into from
Jan 11, 2024

Conversation

gas1cent
Copy link
Member

@gas1cent gas1cent commented Jan 10, 2024 •
edited
Loading

@gas1cent gas1cent requested a review from 0xGorilla January 10, 2024 11:03
@gas1cent gas1cent self-assigned this Jan 10, 2024
@linear Linear
Copy link

linear bot commented Jan 10, 2024

BES-209 Add configuration file

@linear Linear
Copy link

linear bot commented Jan 10, 2024

BES-206 Handle inheritdoc

BES-215 Exclude contracts from the check

@gas1cent gas1cent marked this pull request as ready for review January 10, 2024 18:47
0xGorilla
0xGorilla reviewed Jan 10, 2024
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
0xGorilla
0xGorilla reviewed Jan 10, 2024
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
0xGorilla
0xGorilla reviewed Jan 10, 2024
View reviewed changes
src/main.ts Show resolved Hide resolved
0xGorilla
0xGorilla reviewed Jan 10, 2024
View reviewed changes
src/validator.ts Outdated Show resolved Hide resolved
0xGorilla
0xGorilla reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@0xGorilla 0xGorilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is super clean! Well done, just a few comments before approving

0xGorilla
0xGorilla reviewed Jan 11, 2024
View reviewed changes
src/utils.ts
.filter(sourceUnit => isFileInDirectory(contractsPath, sourceUnit.absolutePath));
.filter(sourceUnit => isFileInDirectory(contractsPath, sourceUnit.absolutePath))
// avoid processing files from ignored directories
.filter(sourceUnit => !ignoredPaths.some(ignoredPath => ignoredPath === sourceUnit.absolutePath));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it happen that ignoredPath has an ending / and absolute path doesn't and stuff like that?
please check isFileInDirectory, I made sure that it is safe to those scenarios

@gas1cent gas1cent merged commit 45c89f1 into main Jan 11, 2024
3 checks passed
@gas1cent gas1cent deleted the feat/config branch January 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGorilla 0xGorilla 0xGorilla approved these changes

Assignees

@gas1cent gas1cent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gas1cent @0xGorilla