Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix to env #1289

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Add prefix to env #1289

merged 1 commit into from
Mar 27, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Mar 12, 2024 •
edited
Loading

Fixes #1288

@mcruzdev
Copy link
Contributor Author

Hi @iocanel this is the only thing that we need to change, makes sense?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mcruzdev
Copy link
Contributor Author

Hi @iocanel, I made some progess with this task, can you review it?

iocanel
iocanel approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcruzdev
Copy link
Contributor Author

Hi @iocanel, TY! This is a flaky test?

@iocanel
Copy link
Member

iocanel commented Mar 26, 2024

I think so yes

@iocanel
Copy link
Member

iocanel commented Mar 27, 2024

Let me re-run them one more time.

@iocanel iocanel merged commit 71e5654 into dekorateio:main Mar 27, 2024
7 of 8 checks passed
@mcruzdev mcruzdev mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support env vars from secrets with a prefix
2 participants
@mcruzdev @iocanel