Merge pull request #57 from McOso/fix/explicit-return

Explicitly set Invoke Return Variable
delegatable · Mar 9, 2023 · 2e2a6ca · 2e2a6ca
2 parents fb34bb2 + f963174
commit 2e2a6ca
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -12,6 +12,7 @@
 
 # KEEP SAFE
 .env
+.envrc
 
 # Development
 abis

diff --git a/contracts/Delegatable.sol b/contracts/Delegatable.sol
@@ -136,7 +136,10 @@ abstract contract Delegatable is IDelegatable, DelegatableCore {
                 invocationSigner,
                 signedInvocations[i].invocations.replayProtection
             );
-            _invoke(signedInvocation.invocations.batch, invocationSigner);
+            success = _invoke(
+                signedInvocation.invocations.batch,
+                invocationSigner
+            );
         }
     }
 

diff --git a/contracts/DelegatableFacet.sol b/contracts/DelegatableFacet.sol
@@ -151,7 +151,10 @@ contract DelegatableFacet is IDelegatable, DelegatableCore {
                 invocationSigner,
                 signedInvocations[i].invocations.replayProtection
             );
-            _invoke(signedInvocation.invocations.batch, invocationSigner);
+            success = _invoke(
+                signedInvocation.invocations.batch,
+                invocationSigner
+            );
         }
     }
 

diff --git a/contracts/DelegatableRelay.sol b/contracts/DelegatableRelay.sol
@@ -134,7 +134,10 @@ contract DelegatableRelay is IDelegatable, DelegatableRelayCore {
                 invocationSigner,
                 signedInvocations[i].invocations.replayProtection
             );
-            _invoke(signedInvocation.invocations.batch, invocationSigner);
+            success = _invoke(
+                signedInvocation.invocations.batch,
+                invocationSigner
+            );
         }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,7 @@ @@
     # KEEP SAFE
     .env
+    .envrc
     # Development
     abis
@@ Expand Down @@