test: assert transferFrom call fails #60
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test which checks the scenario where a malicious party signs an invocation message and sends it to a Delegatable ERC20 contract. The intention of the malicious party is to transfer funds from some other address to their own address.
Impacts test files only.
Motivation
_msgSender()
to check the last 20 bytes of calldata which would be set to the msg.sender (malicious actor's address) in theDelegatableCore._execute
functiontransferFrom
on an ERC20 contract still references the allowances of the msg.sender (or the signer of the first delegation created in the authority chain)