Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the Powermax Metro note #1429

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Revert the Powermax Metro note #1429

merged 4 commits into from
Jan 24, 2025

Conversation

niranjan-n1
Copy link
Contributor

@niranjan-n1 niranjan-n1 commented Jan 22, 2025 •
edited by santhoshatdell
Loading

Description

Revert the Powermax Metro note from v1.14 doc (1.13 version of docs will continue to have the note).
Issue is addressed in dell/csi-powermax#417

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1711

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit bce6ea0. ± Comparison against base commit 58ffb23.

♻️ This comment has been updated with latest results.

@santhoshatdell santhoshatdell marked this pull request as ready for review January 22, 2025 15:48
rsedlock1958
rsedlock1958 reviewed Jan 22, 2025
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No edits required.

satyakonduri
satyakonduri approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@satyakonduri satyakonduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sharmilarama
sharmilarama approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santhoshatdell santhoshatdell merged commit 9fd0344 into main Jan 24, 2025
7 checks passed
@santhoshatdell santhoshatdell deleted the metro_doc_update branch January 24, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@sharmilarama sharmilarama sharmilarama approved these changes

@satyakonduri satyakonduri satyakonduri approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niranjan-n1 @sharmilarama @rsedlock1958 @satyakonduri @santhoshatdell