Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OCP 4.18 support for CSM 1.13 #1446

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Remove OCP 4.18 support for CSM 1.13 #1446

merged 2 commits into from
Feb 6, 2025

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Feb 4, 2025 •
edited
Loading

Description

  • Remove OCP 4.18 support for CSM 1.13
  • Fix spell check errors

cherrypick: 0e243ed7a28969b3ba51c4509fe660b835f64ec2

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1734

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Attaching screenshots

Screenshot 2025-02-05 112851

Screenshot 2025-02-05 112905

@chimanjain
Remove OCP 4.18 support (#1444)
f0b6e79 
* remove ocp 4.18 support

* fix spell check errors
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Test Results

77 tests   77 ✅  3s ⏱️
 3 suites   0 💤
 1 files     0 ❌

Results for commit 98479b7.

♻️ This comment has been updated with latest results.

@chimanjain chimanjain marked this pull request as ready for review February 4, 2025 15:11
@chimanjain chimanjain requested a review from bpjain2004 February 4, 2025 15:12
sharmilarama
sharmilarama approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prablr79
prablr79 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@sharmilarama sharmilarama merged commit 684b575 into release-1.13.0 Feb 6, 2025
7 checks passed
@sharmilarama sharmilarama deleted the remove-ocp-4.18 branch February 6, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgandharva mgandharva mgandharva left review comments

@prablr79 prablr79 prablr79 approved these changes

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chimanjain @prablr79 @bpjain2004 @sharmilarama @nitesh3108 @suryagupta4 @mgandharva