Updated PowerMax Documentation #1450
Conversation
rishabhatdell
requested review from
gallacher,
mjsdell,
prablr79,
rajkumar-palani,
AronAtDell,
sharmilarama and
rsedlock1958
as code owners
| @@ -670,6 +670,8 @@ This feature is also supported for limiting the volume provisioning on Kubernete | |||
|
|
|||
| The CSI Driver for Dell PowerMax supports NVMeTCP from v2.11.0. To enable NVMe/TCP provisioning, blockProtocol in settings file should be specified as NVMETCP. | |||
|
|
|||
| >**NOTE:** <br>If `X_CSI_TRANSPORT_PROTOCOL` is not specified in the powermax-array-config ConfigMap, the driver will detect the available initiators on the host and choose the protocol. Priority is given to NVMe/TCP, followed by FC, then iSCSI. | |||
There was a problem hiding this comment.
Should we specify both i.e. AUTO and the empty value as both cases are handled in our driver code base?
There was a problem hiding this comment.
I don't think so, because here
https://github.com/dell/csi-powermax/blob/1c59cc178a2af03fe436bdd9c1ec60159de7be5f/service/service.go#L730
it just accept these values
FIBRE : Returns FC
FC : Returns FC
ISCSI : Returns ISCSI
NVMETCP : Returns NVMETCP
Empty string ("") : Returns an empty string
Invalid value (e.g., AUTO) : Logs an error and returns an empty string
There was a problem hiding this comment.
Auto is a valid input or not, please refer this?
There was a problem hiding this comment.
According to the documentation, if no value is specified, it defaults to "Auto." This means "Auto" is a valid input and should be supported. Supporting "Auto" will ensure consistency with other drivers, such as PowerStore, which also recognize "Auto" as a valid input.
There was a problem hiding this comment.
Added it to csi-powermax and documentation
|
Please add one screenshot of the preview. |
|
Description
This PR updates the priority of CSI PowerMax driver when its set to Auto
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: