Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes about use of writable snapshots for PowerScale #1453

Closed
wants to merge 4 commits into from
Closed

Add notes about use of writable snapshots for PowerScale #1453

wants to merge 4 commits into from

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Feb 17, 2025 •
edited
Loading

Description

Add notes on the implementation and limits of writable snapshots based on the changes to use such snapshots when cloning from source PVC or snapshot.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1763

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Under the section for describing PVCs from snapshot:
pvcfromsnapshot

Under the section for volume cloning:
volumecloning

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   4s ⏱️ -1s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a99f2d2. ± Comparison against base commit c3ceefc.

♻️ This comment has been updated with latest results.

@donatwork donatwork marked this pull request as ready for review February 18, 2025 11:53
rsedlock1958
rsedlock1958 previously requested changes Feb 18, 2025
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed minor changes are required.

@donatwork donatwork dismissed rsedlock1958’s stale review February 18, 2025 12:45

Made changes based on suggestions.

rsedlock1958
rsedlock1958 reviewed Feb 18, 2025
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed. Change "writable snapshot" to "writable snapshots" in two places.

@donatwork
Copy link
Contributor Author

Closing PR as the approach is under review.

@donatwork donatwork closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 approved these changes

@alikdell alikdell Awaiting requested review from alikdell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donatwork @rsedlock1958