Writable snapshot support #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpjain2004
reviewed
Feb 18, 2025
| ) (string, error) { | ||
| // PAPI call: POST https://1.2.3.4:8080/platform/1/quota/quotas | ||
| // { "enforced" : true, | ||
| // "include_snapshots" : false, | ||
| // "include_snapshots" : true, |
There was a problem hiding this comment.
better to retain the current behavior unless it is really required. Snapshot doesn't consume much space- maybe a few bytes for the metadata, and the size is not directly related to the source volume size.
There was a problem hiding this comment.
Writable snaphots could diverge. I do agree that we probably should not include snapshots but this is in goscaleio so the work is already done to expose this so let the applications decide on the business rules. Does not hurt to keep it.
There was a problem hiding this comment.
Although by exposing this we break compatibility. Terraform uses this module as well.
donatwork
requested review from
AkshaySainiDell,
chimanjain,
HarishH-DELL,
meggm,
nitesh3108,
prablr79,
rajkumar-palani,
santhoshatdell and
shefali-malhotra
as code owners
|
Closing PR for now as the solution for the GitHub issue is under discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
PR adds support for the basic APIs for managing writable snapshots.
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
Added the basic Get/List/Create/Delete functions for managing writable snapshots.