-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip][ffi] transaction and append data FFI #550
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 83.45% 83.05% -0.40%
==========================================
Files 74 74
Lines 16877 17009 +132
Branches 16877 17009 +132
==========================================
+ Hits 14084 14127 +43
- Misses 2135 2225 +90
+ Partials 658 657 -1 ☔ View full report in Codecov by Sentry. |
|
||
#[cfg(feature = "default-engine")] | ||
#[no_mangle] | ||
pub unsafe extern "C" fn get_engine_data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Seems we're passing in ownership. Should we call this into_engine_data
?
What changes are proposed in this pull request?
Transaction
including creation, adding commit info, adding write metadata, and committingThis PR affects the following public APIs
TODO
How was this change tested?
write_table