Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip][ffi] transaction and append data FFI #550

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zachschuermann
Copy link
Collaborator

@zachschuermann zachschuermann commented Nov 27, 2024

What changes are proposed in this pull request?

  1. all new FFI for Transaction including creation, adding commit info, adding write metadata, and committing
  2. new default engine FFI for writing parquet
  3. write_table C example

This PR affects the following public APIs

TODO

How was this change tested?

  1. new C example write_table
  2. TODO more rust tests with miri enabled

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (c3a868f) to head (bbf0a86).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ffi/src/lib.rs 0.00% 72 Missing ⚠️
ffi/src/engine_data.rs 0.00% 17 Missing ⚠️
ffi/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   83.45%   83.05%   -0.40%     
==========================================
  Files          74       74              
  Lines       16877    17009     +132     
  Branches    16877    17009     +132     
==========================================
+ Hits        14084    14127      +43     
- Misses       2135     2225      +90     
+ Partials      658      657       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Nov 27, 2024

#[cfg(feature = "default-engine")]
#[no_mangle]
pub unsafe extern "C" fn get_engine_data(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Seems we're passing in ownership. Should we call this into_engine_data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants