Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new feature flag default-engine-rustls #572

Merged
21 changes: 18 additions & 3 deletions kernel/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ hdfs-native-object-store = { workspace = true, optional = true }
# Used in default and sync engine
parquet = { workspace = true, optional = true }
# Used for fetching direct urls (like pre-signed urls)
reqwest = { version = "0.12.7", optional = true }
reqwest = { version = "0.12.8", default-features = false, optional = true }
strum = { version = "0.26", features = ["derive"] }


Expand All @@ -76,7 +76,10 @@ cloud = [
"hdfs-native-object-store",
]
default = []
default-engine = [

# this is an 'internal' feature flag which has all the shared bits from default-engine and
# default-engine-rustls
_default_engine_base = [
zachschuermann marked this conversation as resolved.
Show resolved Hide resolved
"arrow-conversion",
"arrow-expression",
"arrow-array",
Expand All @@ -89,12 +92,24 @@ default-engine = [
"object_store",
"parquet/async",
"parquet/object_store",
"reqwest",
"tokio",
"uuid/v4",
"uuid/fast-rng",
]

# the default-engine use the reqwest crate with default features which uses native-tls. if you want
# to instead use rustls, use 'default-engine-rustls' which has no native-tls dependency
default-engine = [
"_default_engine_base",
"reqwest/default",
]

default-engine-rustls = [
zachschuermann marked this conversation as resolved.
Show resolved Hide resolved
"_default_engine_base",
"reqwest/rustls-tls-native-roots",
"reqwest/http2",
]

developer-visibility = []
sync-engine = [
"arrow-cast",
Expand Down
Loading