[fix] move parquet_stats_skipping to predicates module
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why there were so many formatting changes..? |
zachschuermann
commented
Dec 15, 2024
There was a problem hiding this comment.
all changes are just formatting - not sure why they are just now getting applied?
zachschuermann
commented
Dec 15, 2024
There was a problem hiding this comment.
all changes are just formatting - not sure why they are just now getting applied?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
- Coverage 83.46% 83.45% -0.02%
==========================================
Files 74 74
Lines 16893 16877 -16
Branches 16893 16877 -16
==========================================
- Hits 14100 14084 -16
Misses 2135 2135
Partials 658 658 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
breaking-change
zachschuermann
changed the title
parquet_stats_skipping to expressions moduleparquet_stats_skipping to predicates module
nicklan
approved these changes
Dec 17, 2024
| @@ -236,7 +234,7 @@ impl ParquetStatsProvider for NullCountTestFilter { | |||
| fn test_eval_is_null() { | |||
| let expressions = [ | |||
| Expr::is_null(column_expr!("x")), | |||
| !Expr::is_null(column_expr!("x")) | |||
| !Expr::is_null(column_expr!("x")), | |||
There was a problem hiding this comment.
huh Im surprised formatting ended up adding this comma
OussamaSaoudi-db
approved these changes
Dec 17, 2024
zachschuermann
added a commit
that referenced
this pull request
Dec 17, 2024
actual 0.6.0 release occurring now, ran into a build issue last friday which was fixed in #602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our builds are actually broken due to a dependency on
mod engineinscan/mod.rs(which only exists when one of the engine feature-flags is enabled. as soon as all are off, it fails to build). This fixes the issue by moving theparquet_stats_skippingmodule out of engine code and intoexpressionsmodule. This was trivial since it actually doesn't depend on any engine code.We pull
parquet_stats_skippingintoscan/mod.rsin order toimpl ParquetStatsProvider for NoStats. Now instead of having this rely on engine code, it's moved to thepredicatesmodule (which is always included)Note that I have a new test in CI that will catch this failure in the future: #601