Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eval_sql_where available to DefaultPredicateEvaluator #627

Merged
merged 17 commits into from
Jan 16, 2025

Support OR as well

56b7351
Select commit
Loading
Failed to load commit list.
Merged

Make eval_sql_where available to DefaultPredicateEvaluator #627

Support OR as well
56b7351
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 1s

83.66% (-0.01%) compared to 76c65c8, passed because coverage increased by 0.03% when compared to adjusted base (83.62%)

View this Pull Request on Codecov

83.66% (-0.01%) compared to 76c65c8, passed because coverage increased by 0.03% when compared to adjusted base (83.62%)

Details

Codecov Report

Attention: Patch coverage is 81.86813% with 33 lines in your changes missing coverage. Please review.

Project coverage is 83.66%. Comparing base (76c65c8) to head (56b7351).

Files with missing lines Patch % Lines
kernel/src/predicates/tests.rs 43.13% 0 Missing and 29 partials ⚠️
kernel/src/scan/data_skipping/tests.rs 97.43% 2 Missing ⚠️
kernel/src/expressions/mod.rs 85.71% 1 Missing ⚠️
kernel/src/scan/data_skipping.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   83.66%   83.66%   -0.01%     
==========================================
  Files          75       75              
  Lines       16909    16949      +40     
  Branches    16909    16949      +40     
==========================================
+ Hits        14147    14180      +33     
+ Misses       2099     2085      -14     
- Partials      663      684      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.