Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delta] Block alter command from overriding or unsetting coordinated commits properties #3573

Conversation

yumingxuanguo-db
Copy link
Contributor

  1. Blocks ALTER TABLE command from setting Coordinated Commits properties if the table already had them. If the table did not have them, checks that the CC property overrides contains exactly Coordinator Name and Coordinator Conf, no Table Conf.
  2. Blocks ALTER TABLE command from unsetting Coordinated Commits properties if the table already has them.
  3. Added UTs for both cases. Moved the UT to a new suite CoordinatedCommitsUtilsSuite.scala.
  4. Renamed some methods for clarity.

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

How was this patch tested?

UTs.

Does this PR introduce any user-facing changes?

No.

@yumingxuanguo-db yumingxuanguo-db force-pushed the block-alter-from-overriding-or-unsetting-cc-properties branch 3 times, most recently from 1844376 to ce29d7d Compare August 31, 2024 05:11
Copy link
Collaborator

@prakharjain09 prakharjain09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some UTs have been deleted. Maybe an issue in adding new file to git commit.

@prakharjain09 prakharjain09 self-requested a review September 3, 2024 16:58
@yumingxuanguo-db yumingxuanguo-db force-pushed the block-alter-from-overriding-or-unsetting-cc-properties branch from acd5e44 to a882cf9 Compare September 3, 2024 17:22
@allisonport-db allisonport-db merged commit 0bfe331 into delta-io:master Sep 4, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants