[Kernel] Enable writing to tables at version 7 when no invariants are defined in the schema #4027
+66
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiyuandong-db
force-pushed
the
delta-kernel-allow-invariants-in-writer-version-7
branch
from
a2bd58e to
e36297d
Compare
qiyuandong-db
changed the title
johanl-db
approved these changes
Jan 9, 2025
kernel/kernel-api/src/main/java/io/delta/kernel/internal/TableFeatures.java
Outdated
Show resolved
Hide resolved
| ) | ||
| } | ||
|
|
||
| test("validateWriteSupported: protocol 7 with invariants, schema contains invariants") { |
There was a problem hiding this comment.
nit
Suggested change
| test("validateWriteSupported: protocol 7 with invariants, schema contains invariants") { | |
| test("validateWriteUnsupported: protocol 7 with invariants, schema contains invariants") { |
There was a problem hiding this comment.
I was also thinking about the name. I found this test suite consistently uses test("validateWriteSupported: ...") even for unsupported cases. So I thought it might be better to follow the same convention.
…Features.java Co-authored-by: Johan Lasperas <[email protected]>
scottsand-db
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Currently, Kernel doesn't support the
invariantsfeature and could not write to tables on writer version 7 if theirwriterFeaturescontainsinvariants.With this change, Kernel will allow
invariantsto be present in thewriterFeaturesfor tables on writer version 7, provided the schema does not define any invariants. This unblocks Kernel from writing to such tables.How was this patch tested?
Tests are added in
TableFeaturesSuite.scala. It also added a missing integration test inRowTrackingSuite.scalathat was previously blocked byinvariants.Does this PR introduce any user-facing changes?
No.