Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Introduce the DeltaTransaction trait #4100

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

ctring
Copy link
Contributor

@ctring ctring commented Jan 29, 2025

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

The OptimisticTransactionImpl trait is bloating as more features are added, making it difficult to extend from. This PR introduces DeltaTransaction, which is conceptually more general to support other implementations of the transaction, containing minimal number of fields that are essential for a transaction and necessary for the post-commit hooks.

How was this patch tested?

unit test

Does this PR introduce any user-facing changes?

no

Copy link
Collaborator

@prakharjain09 prakharjain09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@ctring ctring force-pushed the delta-transaction-base branch from 6b52799 to 7430be5 Compare January 30, 2025 00:41
@scottsand-db scottsand-db merged commit 785ec3c into delta-io:master Jan 30, 2025
16 of 19 checks passed
@ctring ctring deleted the delta-transaction-base branch January 30, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants