Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure, deep links in the help are working #755

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

r10s
Copy link
Member

@r10s r10s commented Nov 16, 2023

we're using some deep link anchors meanwhile in the apps, make sure, these links are always working -
and not get lost on updates or translations.

we're using some deep link anchors meanwhile in the apps,
make sure, these links are always working -
and not get lost on updates or translations.
@r10s r10s requested review from Simon-Laux and adbenitez November 16, 2023 21:05
Copy link

Check out the page preview at https://staging.delta.chat/755/en/

Copy link
Member

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just wondering that!!! and was manually testing if they are the same for the Spanish page of the FAQ

@r10s
Copy link
Member Author

r10s commented Nov 16, 2023

I was just wondering that!!! and was manually testing if they are the same for the Spanish page of the FAQ

:)

in fact, the script also checks all internal links (they are partly even translated)

and also pings all external links, checking that this is 200 OK or so

but still good to have a manual look on that, i also do that for german (and a bit randomly and roughly on other languages)

@r10s r10s merged commit 23db5b2 into master Nov 16, 2023
2 checks passed
@r10s r10s deleted the check-used-anchors branch November 16, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants