Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing ui integration tutorial #1493

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

barryyosi-panw
Copy link
Contributor

Status

Ready

Description

Fixing indentations for improved comprehension and readability.

Copy link

welcome bot commented Feb 12, 2024

Welcome! Thank you and congrats on your first pull request.

What happens next?

  • CircleCI is building a preview of the site with your modifications.
  • Once the build is complete a preview will be available and a comment with a link will be posted.
  • A member of the team will then review the pull request and provide feedback as needed.
  • If all is good and the pull request has passed review, you will be able to merge the PR.

Good luck to us all!

@@ -184,10 +184,10 @@ class Client(BaseClient):
self.api_key = api_key

if self.api_key:
self._headers = {'X-Funtranslations-Api-Secret': self.api_key}
self._headers = {'X-Funtranslations-Api-Secret': self.api_key}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the indentation needs to be fixed

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1493-dq9prrkj.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1493-dq9prrkj.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

Copy link
Contributor

@michal-dagan michal-dagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@barryyosi-panw barryyosi-panw merged commit 9cddd87 into master Feb 12, 2024
8 checks passed
@barryyosi-panw barryyosi-panw deleted the fixing-ui-integration-tutorial branch February 12, 2024 11:20
Copy link

welcome bot commented Feb 12, 2024

Congrats on merging your first pull request!

We are now creating a production deploy. In about 30 minutes our site: https://xsoar.pan.dev will be updated with the changes from this PR.

@xsoar-bot
Copy link

Production Site Updated

Congratulations! The automatic build has completed successfully.
The production site of our docs has been updated. You can view it at: https://xsoar.pan.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants