Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultDataSource #1646

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add defaultDataSource #1646

merged 2 commits into from
Oct 28, 2024

Conversation

BEAdi
Copy link
Contributor

@BEAdi BEAdi commented Oct 27, 2024

Status

Ready/In Progress/In Hold (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

@BEAdi BEAdi self-assigned this Oct 27, 2024
@BEAdi BEAdi removed the request for review from ShirleyDenkberg October 27, 2024 15:13
Copy link
Contributor

@julieschwartz18 julieschwartz18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TW review complete

docs/packs/packs-format.md Outdated Show resolved Hide resolved
docs/packs/packs-format.md Outdated Show resolved Hide resolved
docs/packs/packs-format.md Outdated Show resolved Hide resolved
@julieschwartz18
Copy link
Contributor

Doc review complete. I added the docs-approved tag

@BEAdi
Copy link
Contributor Author

BEAdi commented Oct 28, 2024

Force merge: circle ci is not yet removed so the build fails.

@kobymeir kobymeir added the ForceMerge Forcing the merge of the PR despite the build status label Oct 28, 2024
@kobymeir kobymeir merged commit b9afcaa into master Oct 28, 2024
6 of 7 checks passed
@kobymeir kobymeir deleted the add-defaultDataSource branch October 28, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants