feat: events for ng #26908
Closed
feat: events for ng #26908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 18, 2024
cli/tools/run/mod.rs
Outdated
Comment on lines
82
to
86
| deno_runtime::ops::otel::report_event("deno_boot_failure", e) | ||
| })?; | ||
|
|
||
| let exit_code = worker.run().await.inspect_err(|e| { | ||
| deno_runtime::ops::otel::report_event("deno_uncaught_exception", e) |
There was a problem hiding this comment.
I'm a bit worried about spread of these semi-random strings throughout the codebase. Maybe we could create a deno_otel crate that all other crates pull that contains a list of static: &str EVENT_NAME = "event_name; vars that we can use?
piscisaureus
reviewed
Dec 9, 2024
cli/tools/run/mod.rs
Outdated
| })?; | ||
|
|
||
| let exit_code = worker.run().await.inspect_err(|e| { | ||
| deno_runtime::ops::otel::report_event("deno_uncaught_exception", e) |
There was a problem hiding this comment.
Suggested change
| deno_runtime::ops::otel::report_event("deno_uncaught_exception", e) | |
| deno_runtime::ops::otel::report_event("uncaught_exception", e) |
piscisaureus
reviewed
Dec 9, 2024
cli/tools/run/mod.rs
Outdated
| let exit_code = worker.run().await?; | ||
| .await | ||
| .inspect_err(|e| { | ||
| deno_runtime::ops::otel::report_event("deno_boot_failure", e) |
There was a problem hiding this comment.
Suggested change
| deno_runtime::ops::otel::report_event("deno_boot_failure", e) | |
| deno_runtime::ops::otel::report_event("boot_failure", e) |
cli/tools/run/mod.rs
Outdated
| let exit_code = worker.run().await?; | ||
| .await | ||
| .inspect_err(|e| { | ||
| deno_telemetry::report_event("deno_boot_failure", e) |
There was a problem hiding this comment.
Suggested change
| deno_telemetry::report_event("deno_boot_failure", e) | |
| deno_telemetry::report_event("boot_failure", e) |
There was a problem hiding this comment.
this could conflict with user code emitting events
Signed-off-by: Bert Belder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ng events with well-known names.