feat(lint): add JavaScript plugin support #27203
Conversation
| let diagnostic_range = SourceRange::new(start_pos + start, start_pos + end); | ||
| if !source_range.contains(&diagnostic_range) { | ||
| return Err(LintReportError::DiagnosticIncorrectRange { | ||
| // JS uses 1-based indexes |
There was a problem hiding this comment.
Why is it 1-based? Can we change this to 0-based?
There was a problem hiding this comment.
AFAIU we wanted to use 1-based to mimic ESLint API that also uses 1-based offsets
There was a problem hiding this comment.
Maybe we should just do zero if we're not going for backwards compatibility?
There was a problem hiding this comment.
Looks like this is what eslint does: https://eslint.org/docs/latest/extend/custom-rules#reporting-problems
There was a problem hiding this comment.
Ah, I see this is just for the error shown to the user. I misunderstood. Probalby we should show line and column numbers here?
There was a problem hiding this comment.
How can I show line and column number here if the passed range is not within the SourceRange?
| @@ -258,3 +317,87 @@ fn apply_lint_fixes( | |||
| deno_ast::apply_text_changes(text_info.text_str(), quick_fixes); | |||
| Some(new_text) | |||
| } | |||
|
|
|||
| fn run_plugins( | |||
| plugin_runner: Arc<Mutex<PluginHostProxy>>, | |||
There was a problem hiding this comment.
Maybe we should bury this lock instead of passing it around?
| let diagnostic_range = SourceRange::new(start_pos + start, start_pos + end); | ||
| if !source_range.contains(&diagnostic_range) { | ||
| return Err(LintReportError::DiagnosticIncorrectRange { | ||
| // JS uses 1-based indexes |
There was a problem hiding this comment.
Maybe we should just do zero if we're not going for backwards compatibility?
Nothing to see here yet :))