Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/node): add writev method to FileHandle #27563

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(ext/node): add writev method to FileHandle #27563

wants to merge 5 commits into from
+118 −80

Conversation

aaron-ang
Copy link

@aaron-ang aaron-ang commented Jan 6, 2025 •
edited
Loading

Part of #25554

I merged _fs_writev.mjs and _fs_writev.d.ts into _fs_writev.ts

  • formatted using ./tools/format.js
  • linted using ./tools/lint.js
  • unit test passed in tests/unit_node/_fs/_fs_handle_test.ts

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aaron-ang aaron-ang changed the title fix(ext/node): add writev method to FileHandle feat(ext/node): add writev method to FileHandle Jan 6, 2025
@dsherret dsherret requested a review from kt3k January 8, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k Awaiting requested review from kt3k

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaron-ang @CLAassistant