refactor(node_resolver): make conditions_from_resolution_mode configurable #27596
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note change is breaking |
theswerd
changed the title
theswerd
changed the title
…no more memory issues
dsherret
reviewed
Jan 9, 2025
| @@ -63,6 +66,30 @@ fn conditions_from_resolution_mode( | |||
| } | |||
| } | |||
|
|
|||
| pub struct ConditionsFromResolutionMode { | |||
There was a problem hiding this comment.
Maybe this should just be: pub struct ConditionsFromResolutionMode(Option<Box<dyn Fn(ResolutionMode) -> &'static [&'static str]>>) with a default implementation of ConditionsFromResolutionMode(None) that will instead use deno_conditions_from_resolution_mode? That way the other code can just do ConditionsFromResolutionMode::default() instead of needing to know about deno_conditions_from_resolution_mode
dsherret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user was trying to use Hono node server + react-dom, because node server expects
renderToPipeableStream, because thedenoexport maps to browser, it doesn't have that export, instead it hasrenderToReadableStream. I want to be able to configurably choose module priority based on if users are more leaning into deno or node.