Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compile): support sloppy imports #27944

Merged
merged 3 commits into from
Feb 3, 2025
Merged

feat(compile): support sloppy imports #27944

merged 3 commits into from
Feb 3, 2025
+49 −12

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 3, 2025

Closes #26102

bartlomieju
bartlomieju approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this also enable sloppy resolution in npm packages? If so it'd be nice to have a test for that too.

@dsherret
Copy link
Member Author

dsherret commented Feb 3, 2025

LGTM, does this also enable sloppy resolution in npm packages?

No. We don't ever do sloppy import resolution in npm packages. We only do node resolution there.

@dsherret dsherret merged commit e46860a into denoland:main Feb 3, 2025
18 checks passed
@dsherret dsherret deleted the fix_support_sloppy_imports_deno-compile branch February 3, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support sloppy imports in deno compile
2 participants
@dsherret @bartlomieju