Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/napi): napi_is_buffer tests for ArrayBufferView #27956

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Feb 4, 2025

use correct type check

Fixes: #27951

@devsnek devsnek requested a review from bartlomieju February 4, 2025 11:45
@devsnek devsnek enabled auto-merge (squash) February 4, 2025 13:12
@devsnek devsnek merged commit 98339cf into main Feb 4, 2025
18 checks passed
@devsnek devsnek deleted the x/fix-napi-is-buffer branch February 4, 2025 14:30
bartlomieju pushed a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typed arrays are not correctly handled as buffers in NAPI
2 participants