VACMS-136900: implement text field migration core logic #16227
Conversation
…t-text-field-migration-core-logic
…t-text-field-migration-core-logic
…t-text-field-migration-core-logic
…t-text-field-migration-core-logic
github-actions
bot
changed the title
GitHub Workflows (.github/workflows/*.yml)Have you...
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| string $entityType, | ||
| string $fieldName | ||
| ) { | ||
| $this->reporter = $reporter; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
| * {@inheritDoc} | ||
| */ | ||
| protected function getReporter(): ReporterInterface { | ||
| return $this->reporter; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
| public function run() { | ||
| $this->verifyField($this->getSourceType()); | ||
| $this->backupFieldTables(); | ||
| $this->fieldConfigs = []; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$fieldConfigs.
| $this->verifyField($this->getSourceType()); | ||
| $this->backupFieldTables(); | ||
| $this->fieldConfigs = []; | ||
| $this->formDisplayConfigs = []; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$formDisplayConfigs.
| $this->backupFieldTables(); | ||
| $this->fieldConfigs = []; | ||
| $this->formDisplayConfigs = []; | ||
| $this->viewDisplayConfigs = []; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$viewDisplayConfigs.
| * The bundle. | ||
| */ | ||
| public function updateViewDisplayConfig(string $bundle): void { | ||
| $this->reporter->reportInfo("Updating view display config for field {$this->fieldName} on bundle {$bundle}..."); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
| * The config. | ||
| */ | ||
| public function updateViewDisplayConfigForMode(string $bundle, string $viewMode, array $config): void { | ||
| $this->reporter->reportInfo("Updating view display config for field {$this->fieldName} on bundle {$bundle} for view mode {$viewMode}..."); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
| * {@inheritDoc} | ||
| */ | ||
| public function runMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| * {@inheritDoc} | ||
| */ | ||
| public function rollbackMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| * {@inheritDoc} | ||
| */ | ||
| public function verifyMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| * {@inheritDoc} | ||
| */ | ||
| public function runMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| * {@inheritDoc} | ||
| */ | ||
| public function rollbackMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| * {@inheritDoc} | ||
| */ | ||
| public function verifyMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
|
Checking composer.lock changes... |
| string $entityType, | ||
| string $fieldName, | ||
| string $migrationId, | ||
| string $status = NULL |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing> reported by reviewdog 🐶
Parameter $status has null default value, but is not marked as nullable.
| string $entityType, | ||
| string $fieldName, | ||
| string $migrationId, | ||
| string $status = NULL |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter
| FieldProviderResolverInterface $fieldProviderResolver, | ||
| MigrationResolverInterface $migrationResolver, | ||
| ReporterInterface $reporter, | ||
| StateInterface $state |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter
| $plugin_definition, | ||
| TranslationInterface $stringTranslation, | ||
| ReporterInterface $reporter, | ||
| FactoryInterface $migratorFactory |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter
| ContainerInterface $container, | ||
| array $configuration, | ||
| $plugin_id, | ||
| $plugin_definition |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter
| * The database connection. | ||
| */ | ||
| public function __construct( | ||
| Connection $connection |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter
| $plugin_id, | ||
| $plugin_definition, | ||
| TranslationInterface $stringTranslation, | ||
| EntityFieldManagerInterface $entityFieldManager |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter
| ContainerInterface $container, | ||
| array $configuration, | ||
| $plugin_id, | ||
| $plugin_definition |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| public function getFields(string $entityType, string $bundle = NULL) : array { |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing> reported by reviewdog 🐶
Parameter $bundle has null default value, but is not marked as nullable.
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| public function getFields(string $entityType, string $bundle = NULL) : array { |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing> reported by reviewdog 🐶
Parameter $bundle has null default value, but is not marked as nullable.
| string $entityType, | ||
| string $fieldName | ||
| ) { | ||
| $this->reporter = $reporter; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
| * {@inheritDoc} | ||
| */ | ||
| protected function getReporter(): ReporterInterface { | ||
| return $this->reporter; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
| public function run() { | ||
| $this->verifyField($this->getSourceType()); | ||
| $this->backupFieldTables(); | ||
| $this->fieldConfigs = []; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$fieldConfigs.
| $this->verifyField($this->getSourceType()); | ||
| $this->backupFieldTables(); | ||
| $this->fieldConfigs = []; | ||
| $this->formDisplayConfigs = []; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$formDisplayConfigs.
| $this->backupFieldTables(); | ||
| $this->fieldConfigs = []; | ||
| $this->formDisplayConfigs = []; | ||
| $this->viewDisplayConfigs = []; |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$viewDisplayConfigs.
| * The config. | ||
| */ | ||
| public function updateViewDisplayConfigForMode(string $bundle, string $viewMode, array $config): void { | ||
| $this->reporter->reportInfo("Updating view display config for field {$this->fieldName} on bundle {$bundle} for view mode {$viewMode}..."); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
| * {@inheritDoc} | ||
| */ | ||
| public function runMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| * {@inheritDoc} | ||
| */ | ||
| public function rollbackMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| * {@inheritDoc} | ||
| */ | ||
| public function verifyMigration(string $entityType, string $fieldName) : void { | ||
| $migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
| // When we are on Drupal 10.0.0, we can use the following: | ||
| // Error::logException($this->logger, $exception); | ||
| // Until then, we have to do this: | ||
| watchdog_exception('va_gov_live_field_migration', $exception); |
There was a problem hiding this comment.
[PHPStan] reported by reviewdog 🐶
Call to deprecated function watchdog_exception():
|
Tugboat has finished building the preview for this pull request! Links:
Dashboard: |
Description
Closes #13699.