Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recently changed or added content view. #20427

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

brianseek
Copy link
Contributor

@brianseek brianseek commented Feb 7, 2025

Description

Adds a view page and data export to review updated and new VAMC page content since 1/20/25.

Testing done

Manually tested view in tugboat

Screenshots

pr20427-rwqkt5iz9irlkkmwvszkowhltu9gluiv ci cms va gov_admin_content_recently-changed-added_title_op=contains title= moderation_state=editorial-published revision_log_op=contains revision_log= field_administration_target_id=All

QA steps

What needs to be checked to prove this works?

  • Verify that the view exists after a config import on local.
  • Verify that the exposed filters function as expected.
  • Verify that the CSV export works and reflects the current query.
  • Verify that only logged in users can view the page.
    What needs to be checked to prove it didn't break any related things?
  • Verify that none of the other content related views are effected.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 7, 2025 18:31 Destroyed
Copy link

github-actions bot commented Feb 7, 2025

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 7, 2025 18:59 Destroyed
Copy link

github-actions bot commented Feb 7, 2025

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 7, 2025 20:41 Destroyed
Copy link

github-actions bot commented Feb 7, 2025

Checking composer.lock changes...

@brianseek brianseek marked this pull request as ready for review February 7, 2025 22:29
@brianseek brianseek requested a review from timcosgrove February 7, 2025 22:29
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Feb 7, 2025
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 8, 2025 08:50 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 9, 2025 08:56 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 10, 2025 08:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 11, 2025 08:58 Destroyed
@brianseek brianseek force-pushed the VACMS-20353-new-changed-content-view branch from cfe6362 to 16e56b7 Compare February 11, 2025 21:46
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 11, 2025 21:46 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 12, 2025 09:00 Destroyed
@brianseek brianseek force-pushed the VACMS-20353-new-changed-content-view branch from 16e56b7 to 955160c Compare February 12, 2025 18:00
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 12, 2025 18:00 Destroyed
Copy link

Checking composer.lock changes...

Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 12, 2025 20:09 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-consequatur

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

@brianseek brianseek merged commit 91d1bc7 into main Feb 12, 2025
18 checks passed
@brianseek brianseek deleted the VACMS-20353-new-changed-content-view branch February 12, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants