Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARP POA Submission] (#5) Update POA Form Submission Scopes (#101919)# #20804

Open
wants to merge 5 commits into
base: art/101919/form-submission-check-job
Choose a base branch
from

Conversation

pixiitech
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES/NO yes

    Convert poa request status scopes/predicates
    
    This is so that these internal methods match status params in
    the index endpoint.
    
    - unprocessed -> pending
    - resolved -> processed
    
    They have also been modified to count requests with a PoA form
    submission in an unsuccessful state as pending.
  • (If bug, how to reproduce) change
  • (What is the solution, why is this the solution?) Oren Mittman slack request
  • (Which team do you work for, does your team own the maintenance of this component?) ARF
  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@pixiitech pixiitech changed the base branch from master to art/101919/form-submission-check-job February 14, 2025 16:00
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/sidekiq/accredited_representative_portal/power_of_attorney_form_submission_job_spec.rb

@pixiitech pixiitech force-pushed the art/101919/form-submission-check-job branch from 441da2d to 2a5dfec Compare February 19, 2025 15:24
@pixiitech pixiitech force-pushed the art/101919/update-poa-form-submission-scopes branch from 4af4121 to 518eb09 Compare February 19, 2025 16:40
@pixiitech pixiitech force-pushed the art/101919/update-poa-form-submission-scopes branch from 518eb09 to 9ec71ce Compare February 19, 2025 17:03
@nihil2501 nihil2501 changed the title [ARP POA submission] (#5) Update PoA form submission scopes [ARP POA submission] (#5) Update POA Form Submission Scopes (#101919) Feb 19, 2025
@nihil2501 nihil2501 changed the title [ARP POA submission] (#5) Update POA Form Submission Scopes (#101919) [ARP POA Submission] (#5) Update POA Form Submission Scopes (#101919) Feb 20, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to art/101919/update-poa-form-submission-scopes/main/main February 20, 2025 15:10 Inactive

def processed(relation)
relation
.processed.where.not(resolution: { resolving_type: PowerOfAttorneyRequestExpiration })
Copy link
Contributor Author

@pixiitech pixiitech Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.processed.where.not(resolution: { resolving_type: PowerOfAttorneyRequestExpiration.to_s })

adding .to_s here fixes the 'can't cast class' problem (and includes the namespace in the string)
@nihil2501

@pixiitech pixiitech force-pushed the art/101919/update-poa-form-submission-scopes branch from a5cbc94 to 4f8d13a Compare February 20, 2025 16:40
@va-vfs-bot va-vfs-bot temporarily deployed to art/101919/update-poa-form-submission-scopes/main/main February 20, 2025 16:41 Inactive
@pixiitech pixiitech force-pushed the art/101919/update-poa-form-submission-scopes branch from 4f8d13a to bf2259c Compare February 20, 2025 16:51
@va-vfs-bot va-vfs-bot temporarily deployed to art/101919/update-poa-form-submission-scopes/main/main February 20, 2025 16:52 Inactive
@pixiitech pixiitech force-pushed the art/101919/form-submission-check-job branch from 2a5dfec to fdcee5e Compare February 20, 2025 20:52
@nihil2501 nihil2501 changed the title [ARP POA Submission] (#5) Update POA Form Submission Scopes (#101919) UNREBASED!!! [ARP POA Submission] (#5) Feb 20, 2025
@pixiitech pixiitech force-pushed the art/101919/update-poa-form-submission-scopes branch from bf2259c to 4fc0778 Compare February 21, 2025 16:42
@va-vfs-bot va-vfs-bot temporarily deployed to art/101919/update-poa-form-submission-scopes/main/main February 21, 2025 16:43 Inactive
@pixiitech pixiitech changed the title UNREBASED!!! [ARP POA Submission] (#5) [ARP POA Submission] (#5) Update POA Form Submission Scopes (#101919)# Feb 21, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to art/101919/update-poa-form-submission-scopes/main/main February 21, 2025 16:52 Inactive
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixiitech pixiitech marked this pull request as ready for review February 21, 2025 17:17
@pixiitech pixiitech requested review from a team as code owners February 21, 2025 17:17
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixiitech pixiitech force-pushed the art/101919/form-submission-check-job branch from 47f56c1 to cf9270b Compare February 21, 2025 22:45
@pixiitech pixiitech requested review from a team as code owners February 21, 2025 22:45
pixiitech and others added 4 commits February 21, 2025 17:45
This is so that these internal methods match status params in
the index endpoint.

- unprocessed -> pending
- resolved -> processed

They have also been modified to count requests with a PoA form
submission in an unsuccessful state as pending.
* [ARP] Remove unused serializer

* [ARP] Serialize POA form submission status

* [ARP] Define and use processed POA request scopes

* [ARP] Lint fixes
@pixiitech pixiitech force-pushed the art/101919/update-poa-form-submission-scopes branch from cd2a734 to 658dd8c Compare February 21, 2025 22:48
@va-vfs-bot va-vfs-bot temporarily deployed to art/101919/update-poa-form-submission-scopes/main/main February 21, 2025 22:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants