-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARP POA Submission] (#5) Update POA Form Submission Scopes (#101919)# #20804
base: art/101919/form-submission-check-job
Are you sure you want to change the base?
[ARP POA Submission] (#5) Update POA Form Submission Scopes (#101919)# #20804
Conversation
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/sidekiq/accredited_representative_portal/power_of_attorney_form_submission_job_spec.rb |
441da2d
to
2a5dfec
Compare
4af4121
to
518eb09
Compare
518eb09
to
9ec71ce
Compare
..._portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb
Show resolved
Hide resolved
..._portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb
Show resolved
Hide resolved
|
||
def processed(relation) | ||
relation | ||
.processed.where.not(resolution: { resolving_type: PowerOfAttorneyRequestExpiration }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.processed.where.not(resolution: { resolving_type: PowerOfAttorneyRequestExpiration.to_s })
adding .to_s
here fixes the 'can't cast class' problem (and includes the namespace in the string)
@nihil2501
a5cbc94
to
4f8d13a
Compare
4f8d13a
to
bf2259c
Compare
2a5dfec
to
fdcee5e
Compare
bf2259c
to
4fc0778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
47f56c1
to
cf9270b
Compare
This is so that these internal methods match status params in the index endpoint. - unprocessed -> pending - resolved -> processed They have also been modified to count requests with a PoA form submission in an unsuccessful state as pending.
* [ARP] Remove unused serializer * [ARP] Serialize POA form submission status * [ARP] Define and use processed POA request scopes * [ARP] Lint fixes
cd2a734
to
658dd8c
Compare
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?