Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10EZ] Add field keys for 10-10EZ pdf fill functionality #20852

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Feb 19, 2025

Summary

  • This work is behind a feature toggle (flipper): NO, but it is not being called anywhere yet
  • Add key mapping for vets-json-schema to 10-10EZ pdf file to be used to fill out pdf from form data.
  • This PR is part 1 to just add the key mapping. A future PR will have some updates to ensure the correct values are displayed in the filled out pdf.
  • 1010 Health Apps

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

10-10EZ, pdf filling

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 102888-add-pdf-keys-pt-1/main/main February 19, 2025 17:14 Inactive
@@ -10,6 +10,297 @@ class Va1010ez < FormBase
KEY = {
'veteranFullName' => {
key: 'F[0].P4[0].LastFirstMiddle[0]'
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are tested in the va1010ez_spec.rb file by confirming the generated pdf (simple.pdf) has the correct values filled out. I broke this out into it's own PR to make the diff smaller. These keys align with the vets-json-schema and the 10-10EZ pdf fields.

Copy link

1 Warning
⚠️ This PR changes 291 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • lib/pdf_fill/forms/va1010ez.rb (+291/-0)

Note: We exclude files matching the following when considering PR size:

*.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@coope93 coope93 changed the title add keys for 10-10ez pdf fill [10-10EZ] Add field keys for 10-10EZ pdf fill functionality Feb 19, 2025
@coope93 coope93 marked this pull request as ready for review February 19, 2025 17:27
@coope93 coope93 requested review from a team as code owners February 19, 2025 17:27
@va-vfs-bot va-vfs-bot temporarily deployed to 102888-add-pdf-keys-pt-1/main/main February 19, 2025 17:31 Inactive
Copy link
Contributor

@JoshingYou1 JoshingYou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work Brandon! 😄

@coope93 coope93 merged commit 9a71ac4 into master Feb 20, 2025
30 of 31 checks passed
@coope93 coope93 deleted the 102888-add-pdf-keys-pt-1 branch February 20, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants